isync

commit 92914b37cc696da7774975b59570baf5d2d8a72a
parent 0d8bce1675f5e0c89fa0b7dcf4e7cc0d4f11a821
Author: Oswald Buddenhagen <ossi@users.sf.net>
Date:   Sat, 23 Aug 2008 07:54:00 +0000

deal with UIDVALIDITY of 0 properly.
-REF: 20080822094543.GA3528@ugly.local

Diffstat:
M
src/drv_imap.c
 | 
9
++++++---
M
src/sync.c
 | 
7
++++---

2 files changed, 10 insertions(+), 6 deletions(-)
diff --git a/src/drv_imap.c b/src/drv_imap.c
@@ -882,7 +882,7 @@ parse_capability( imap_store_t *ctx, char *cmd )
 static int
 parse_response_code( imap_store_t *ctx, struct imap_cmd_cb *cb, char *s )
 {
-	char *arg, *p;
+	char *arg, *earg, *p;
 
 	if (*s != '[')
 		return RESP_OK;		/* no response code */
@@ -894,7 +894,9 @@ parse_response_code( imap_store_t *ctx, struct imap_cmd_cb *cb, char *s )
 	*p++ = 0;
 	arg = next_arg( &s );
 	if (!strcmp( "UIDVALIDITY", arg )) {
-		if (!(arg = next_arg( &s )) || !(ctx->gen.uidvalidity = atoi( arg ))) {
+		if (!(arg = next_arg( &s )) ||
+		    (ctx->gen.uidvalidity = strtoll( arg, &earg, 10 ), *earg))
+		{
 			error( "IMAP error: malformed UIDVALIDITY status\n" );
 			return RESP_BAD;
 		}
@@ -912,7 +914,8 @@ parse_response_code( imap_store_t *ctx, struct imap_cmd_cb *cb, char *s )
 		for (; isspace( (unsigned char)*p ); p++);
 		error( "*** IMAP ALERT *** %s\n", p );
 	} else if (cb && cb->ctx && !strcmp( "APPENDUID", arg )) {
-		if (!(arg = next_arg( &s )) || !(ctx->gen.uidvalidity = atoi( arg )) ||
+		if (!(arg = next_arg( &s )) ||
+		    (ctx->gen.uidvalidity = strtoll( arg, &earg, 10 ), *earg) ||
 		    !(arg = next_arg( &s )) || !(*(int *)cb->ctx = atoi( arg )))
 		{
 			error( "IMAP error: malformed APPENDUID status\n" );
diff --git a/src/sync.c b/src/sync.c
@@ -470,13 +470,14 @@ sync_boxes( store_t *ctx[], const char *names[], channel_conf_t *chan,
 	svars->ctx[0] = ctx[0];
 	svars->ctx[1] = ctx[1];
 	svars->chan = chan;
+	svars->uidval[0] = svars->uidval[1] = -1;
 	svars->srecadd = &svars->srecs;
 
 	for (t = 0; t < 2; t++) {
 		ctx[t]->name =
 			(!names[t] || (ctx[t]->conf->map_inbox && !strcmp( ctx[t]->conf->map_inbox, names[t] ))) ?
 				"INBOX" : names[t];
-		ctx[t]->uidvalidity = 0;
+		ctx[t]->uidvalidity = -1;
 		svars->drv[t] = ctx[t]->conf->driver;
 		svars->drv[t]->prepare_paths( ctx[t] );
 	}
@@ -862,7 +863,7 @@ box_selected( int sts, void *aux )
 
 	if (check_ret( sts, svars, t ))
 		return 1;
-	if (svars->uidval[t] && svars->uidval[t] != svars->ctx[t]->uidvalidity) {
+	if (svars->uidval[t] >= 0 && svars->uidval[t] != svars->ctx[t]->uidvalidity) {
 		error( "Error: UIDVALIDITY of %s changed (got %d, expected %d)\n",
 		         str_ms[t], svars->ctx[t]->uidvalidity, svars->uidval[t] );
 		svars->ret |= SYNC_FAIL;
@@ -1056,7 +1057,7 @@ msgs_found_sel( sync_vars_t *svars, int t )
 	if (!(svars->state[1-t] & ST_SENT_FIND_OLD) || svars->find_old_done[1-t] < svars->find_new_total[1-t])
 		return 0;
 
-	if (!svars->uidval[M] || !svars->uidval[S]) {
+	if (svars->uidval[M] < 0 || svars->uidval[S] < 0) {
 		svars->uidval[M] = svars->ctx[M]->uidvalidity;
 		svars->uidval[S] = svars->ctx[S]->uidvalidity;
 		Fprintf( svars->jfp, "| %d %d\n", svars->uidval[M], svars->uidval[S] );