commit 4504229ef8b6a3aaf9c8af083e616a3c0132d4b2 parent 9585373631337d115a61f4fb3646950945f9ec58 Author: Chris Bracken <chris@bracken.jp> Date: Fri, 6 Mar 2026 19:38:40 +0900 Eliminate unnecessary nulling in _free functions These were there to help with debugging earlier on, but they're no longer necessary. Diffstat:
36 files changed, 0 insertions(+), 99 deletions(-)
diff --git a/src/git/commit.c b/src/git/commit.c @@ -61,7 +61,6 @@ GitCommit* gitcommit_create(const git_oid* oid, git_repository* repo) { errx(1, "git_tree_lookup"); } git_commit_free(parent); - parent = NULL; } // Compute the diff. @@ -126,10 +125,7 @@ void gitcommit_free(GitCommit* commit) { free(commit->author_email); for (size_t i = 0; i < commit->deltas_len; i++) { gitdelta_free(commit->deltas[i]); - commit->deltas[i] = NULL; } free(commit->deltas); - commit->deltas = NULL; - free(commit); } diff --git a/src/git/delta.c b/src/git/delta.c @@ -83,10 +83,8 @@ static void githunk_free(GitHunk* hunk) { free(hunk->header); for (size_t i = 0; i < hunk->lines_len; i++) { githunkline_free(hunk->lines[i]); - hunk->lines[i] = NULL; } free(hunk->lines); - hunk->lines = NULL; free(hunk); } @@ -171,10 +169,8 @@ void gitdelta_free(GitDelta* delta) { free(delta->new_file_path); for (size_t i = 0; i < delta->hunks_len; i++) { githunk_free(delta->hunks[i]); - delta->hunks[i] = NULL; } free(delta->hunks); - delta->hunks = NULL; free(delta); } diff --git a/src/git/git.c b/src/git/git.c @@ -110,9 +110,7 @@ static void libgit2_for_repo(Git* git, git->repo = gitrepo_create_from_repository(git->fs, path, git->impl); cb(git, user_data); gitrepo_free(git->repo); - git->repo = NULL; git_repository_free((git_repository*)git->impl); - git->impl = NULL; } static void libgit2_for_each_commit(const Git* git, diff --git a/src/git/reference.c b/src/git/reference.c @@ -67,9 +67,7 @@ void gitreference_free(GitReference* ref) { return; } free(ref->shorthand); - ref->shorthand = NULL; gitcommit_free(ref->commit); - ref->commit = NULL; free(ref); } diff --git a/src/git/repo.c b/src/git/repo.c @@ -236,23 +236,14 @@ void gitrepo_free(GitRepo* repo) { return; } free(repo->name); - repo->name = NULL; free(repo->short_name); - repo->short_name = NULL; free(repo->owner); - repo->owner = NULL; free(repo->description); - repo->description = NULL; free(repo->clone_url); - repo->clone_url = NULL; - for (size_t i = 0; i < repo->special_files_len; i++) { free(repo->special_files[i].label); free(repo->special_files[i].path); } free(repo->special_files); - repo->special_files = NULL; - repo->special_files_len = 0; - free(repo); } diff --git a/src/gout_index.c b/src/gout_index.c @@ -66,7 +66,6 @@ void gout_index_options_free(GoutIndexOptions* options) { } if (options->repo_dirs) { free(options->repo_dirs); - options->repo_dirs = NULL; } free(options); } diff --git a/src/writer/cache/cache.c b/src/writer/cache/cache.c @@ -114,7 +114,6 @@ void cache_free(Cache* cache) { free(cache->cache_path); free(cache->temp_cache_path); free(cache->lastoid_in); - cache->lastoid_in = NULL; free(cache); } diff --git a/src/writer/gemini/commit.c b/src/writer/gemini/commit.c @@ -66,9 +66,7 @@ void gemini_commit_free(GeminiCommit* commit) { return; } commit->fs->fclose(commit->out); - commit->out = NULL; gemini_page_free(commit->page); - commit->page = NULL; free(commit); } diff --git a/src/writer/gemini/fileblob.c b/src/writer/gemini/fileblob.c @@ -75,9 +75,7 @@ void gemini_fileblob_free(GeminiFileBlob* blob) { return; } blob->fs->fclose(blob->out); - blob->out = NULL; gemini_page_free(blob->page); - blob->page = NULL; free(blob); } diff --git a/src/writer/gemini/files.c b/src/writer/gemini/files.c @@ -36,9 +36,7 @@ void gemini_files_free(GeminiFiles* files) { return; } files->fs->fclose(files->out); - files->out = NULL; gemini_page_free(files->page); - files->page = NULL; free(files); } diff --git a/src/writer/gemini/index_writer.c b/src/writer/gemini/index_writer.c @@ -24,7 +24,6 @@ void gemini_indexwriter_free(GeminiIndexWriter* writer) { return; } gemini_repoindex_free(writer->index); - writer->index = NULL; free(writer); } diff --git a/src/writer/gemini/log.c b/src/writer/gemini/log.c @@ -46,11 +46,8 @@ void gemini_log_free(GeminiLog* log) { return; } log->fs->fclose(log->out); - log->out = NULL; cache_free(log->cache); - log->cache = NULL; gemini_page_free(log->page); - log->page = NULL; free(log); } diff --git a/src/writer/gemini/page.c b/src/writer/gemini/page.c @@ -39,9 +39,7 @@ void gemini_page_free(GeminiPage* page) { return; } free(page->title); - page->title = NULL; free(page->relpath); - page->relpath = NULL; free(page); } diff --git a/src/writer/gemini/refs.c b/src/writer/gemini/refs.c @@ -39,9 +39,7 @@ void gemini_refs_free(GeminiRefs* refs) { return; } refs->fs->fclose(refs->out); - refs->out = NULL; gemini_page_free(refs->page); - refs->page = NULL; free(refs); } diff --git a/src/writer/gemini/repo_index.c b/src/writer/gemini/repo_index.c @@ -21,7 +21,6 @@ void gemini_repoindex_free(GeminiRepoIndex* index) { if (!index) { return; } - index->out = NULL; free(index); } diff --git a/src/writer/gemini/repo_writer.c b/src/writer/gemini/repo_writer.c @@ -59,23 +59,16 @@ void gemini_repowriter_free(GeminiRepoWriter* writer) { return; } gemini_refs_free(writer->refs); - writer->refs = NULL; gemini_log_free(writer->log); - writer->log = NULL; atom_free(writer->atom); - writer->atom = NULL; if (writer->atom_out) { writer->fs->fclose(writer->atom_out); - writer->atom_out = NULL; } atom_free(writer->tags); - writer->tags = NULL; if (writer->tags_out) { writer->fs->fclose(writer->tags_out); - writer->tags_out = NULL; } gemini_files_free(writer->files); - writer->files = NULL; free(writer); } diff --git a/src/writer/gopher/commit.c b/src/writer/gopher/commit.c @@ -66,9 +66,7 @@ void gopher_commit_free(GopherCommit* commit) { return; } commit->fs->fclose(commit->out); - commit->out = NULL; gopher_page_free(commit->page); - commit->page = NULL; free(commit); } diff --git a/src/writer/gopher/fileblob.c b/src/writer/gopher/fileblob.c @@ -75,9 +75,7 @@ void gopher_fileblob_free(GopherFileBlob* blob) { return; } blob->fs->fclose(blob->out); - blob->out = NULL; gopher_page_free(blob->page); - blob->page = NULL; free(blob); } diff --git a/src/writer/gopher/files.c b/src/writer/gopher/files.c @@ -36,9 +36,7 @@ void gopher_files_free(GopherFiles* files) { return; } files->fs->fclose(files->out); - files->out = NULL; gopher_page_free(files->page); - files->page = NULL; free(files); } diff --git a/src/writer/gopher/index_writer.c b/src/writer/gopher/index_writer.c @@ -24,7 +24,6 @@ void gopher_indexwriter_free(GopherIndexWriter* writer) { return; } gopher_repoindex_free(writer->index); - writer->index = NULL; free(writer); } diff --git a/src/writer/gopher/log.c b/src/writer/gopher/log.c @@ -46,11 +46,8 @@ void gopher_log_free(GopherLog* log) { return; } log->fs->fclose(log->out); - log->out = NULL; cache_free(log->cache); - log->cache = NULL; gopher_page_free(log->page); - log->page = NULL; free(log); } diff --git a/src/writer/gopher/page.c b/src/writer/gopher/page.c @@ -39,9 +39,7 @@ void gopher_page_free(GopherPage* page) { return; } free(page->title); - page->title = NULL; free(page->relpath); - page->relpath = NULL; free(page); } diff --git a/src/writer/gopher/refs.c b/src/writer/gopher/refs.c @@ -52,9 +52,7 @@ static void gopher_refstable_free(GopherRefsTable* table) { return; } free(table->title); - table->title = NULL; free(table->id); - table->id = NULL; free(table); } @@ -108,13 +106,9 @@ void gopher_refs_free(GopherRefs* refs) { return; } refs->fs->fclose(refs->out); - refs->out = NULL; gopher_page_free(refs->page); - refs->page = NULL; gopher_refstable_free(refs->branches); - refs->branches = NULL; gopher_refstable_free(refs->tags); - refs->tags = NULL; free(refs); } diff --git a/src/writer/gopher/repo_index.c b/src/writer/gopher/repo_index.c @@ -21,7 +21,6 @@ void gopher_repoindex_free(GopherRepoIndex* index) { if (!index) { return; } - index->out = NULL; free(index); } diff --git a/src/writer/gopher/repo_writer.c b/src/writer/gopher/repo_writer.c @@ -59,23 +59,16 @@ void gopher_repowriter_free(GopherRepoWriter* writer) { return; } gopher_refs_free(writer->refs); - writer->refs = NULL; gopher_log_free(writer->log); - writer->log = NULL; atom_free(writer->atom); - writer->atom = NULL; if (writer->atom_out) { writer->fs->fclose(writer->atom_out); - writer->atom_out = NULL; } atom_free(writer->tags); - writer->tags = NULL; if (writer->tags_out) { writer->fs->fclose(writer->tags_out); - writer->tags_out = NULL; } gopher_files_free(writer->files); - writer->files = NULL; free(writer); } diff --git a/src/writer/html/commit.c b/src/writer/html/commit.c @@ -69,9 +69,7 @@ void html_commit_free(HtmlCommit* commit) { return; } commit->fs->fclose(commit->out); - commit->out = NULL; html_page_free(commit->page); - commit->page = NULL; free(commit); } diff --git a/src/writer/html/fileblob.c b/src/writer/html/fileblob.c @@ -75,9 +75,7 @@ void html_fileblob_free(HtmlFileBlob* blob) { return; } blob->fs->fclose(blob->out); - blob->out = NULL; html_page_free(blob->page); - blob->page = NULL; free(blob); } diff --git a/src/writer/html/files.c b/src/writer/html/files.c @@ -36,9 +36,7 @@ void html_files_free(HtmlFiles* files) { return; } files->fs->fclose(files->out); - files->out = NULL; html_page_free(files->page); - files->page = NULL; free(files); } diff --git a/src/writer/html/index_writer.c b/src/writer/html/index_writer.c @@ -24,7 +24,6 @@ void html_indexwriter_free(HtmlIndexWriter* writer) { return; } html_repoindex_free(writer->index); - writer->index = NULL; free(writer); } diff --git a/src/writer/html/log.c b/src/writer/html/log.c @@ -46,11 +46,8 @@ void html_log_free(HtmlLog* log) { return; } log->fs->fclose(log->out); - log->out = NULL; cache_free(log->cache); - log->cache = NULL; html_page_free(log->page); - log->page = NULL; free(log); } diff --git a/src/writer/html/page.c b/src/writer/html/page.c @@ -38,9 +38,7 @@ void html_page_free(HtmlPage* page) { return; } free(page->title); - page->title = NULL; free(page->relpath); - page->relpath = NULL; free(page); } diff --git a/src/writer/html/refs.c b/src/writer/html/refs.c @@ -52,9 +52,7 @@ static void html_refstable_free(HtmlRefsTable* table) { return; } free(table->title); - table->title = NULL; free(table->id); - table->id = NULL; free(table); } @@ -110,13 +108,9 @@ void html_refs_free(HtmlRefs* refs) { return; } refs->fs->fclose(refs->out); - refs->out = NULL; html_page_free(refs->page); - refs->page = NULL; html_refstable_free(refs->branches); - refs->branches = NULL; html_refstable_free(refs->tags); - refs->tags = NULL; free(refs); } diff --git a/src/writer/html/repo_index.c b/src/writer/html/repo_index.c @@ -23,7 +23,6 @@ void html_repoindex_free(HtmlRepoIndex* index) { if (!index) { return; } - index->out = NULL; free(index); } diff --git a/src/writer/html/repo_writer.c b/src/writer/html/repo_writer.c @@ -59,23 +59,16 @@ void html_repowriter_free(HtmlRepoWriter* writer) { return; } html_refs_free(writer->refs); - writer->refs = NULL; html_log_free(writer->log); - writer->log = NULL; atom_free(writer->atom); - writer->atom = NULL; if (writer->atom_out) { writer->fs->fclose(writer->atom_out); - writer->atom_out = NULL; } atom_free(writer->tags); - writer->tags = NULL; if (writer->tags_out) { writer->fs->fclose(writer->tags_out); - writer->tags_out = NULL; } html_files_free(writer->files); - writer->files = NULL; free(writer); } diff --git a/src/writer/index_writer.c b/src/writer/index_writer.c @@ -124,7 +124,6 @@ void indexwriter_free(IndexWriter* writer) { return; } writer->ops->free(writer->impl); - writer->impl = NULL; free(writer); } diff --git a/src/writer/repo_writer.c b/src/writer/repo_writer.c @@ -199,7 +199,6 @@ void repowriter_free(RepoWriter* writer) { return; } writer->ops->free(writer->impl); - writer->impl = NULL; free(writer); }